Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on ad hoc constant limitations. #372

Conversation

hoffbrinkle
Copy link
Contributor

Ad hoc constants no longer have significant limitations with unit labels.

@hoffbrinkle hoffbrinkle force-pushed the hoffbrinkle/ad_hoc_constant_limitations branch 2 times, most recently from 557b7da to 0be73c7 Compare December 31, 2024 17:08
Ad hoc constants no longer have significant limitations with unit labels.
Copy link
Contributor

@chiphogg chiphogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! This is good to land once the latest main gets merged in. I've included two optional tweaks as well.

docs/reference/constant.md Outdated Show resolved Hide resolved
docs/reference/constant.md Outdated Show resolved Hide resolved
@chiphogg
Copy link
Contributor

chiphogg commented Jan 1, 2025

Thanks for catching this! This is good to land once the latest main gets merged in. I've included two optional tweaks as well.

Apparently, I'm able to merge the latest main myself. I'll go ahead and land this after applying the suggestions.

@chiphogg chiphogg merged commit 74ebfc0 into aurora-opensource:main Jan 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants