Add labels for integer and rational magnitudes #331
Merged
+117
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think of this as "just enough of #85 to unblock #105". The fact that
our common unit labels don't tell you the size of the unit (#105) has
really, really been bugging me for a long time. Recently, I realized we
don't need to do all of #85 to get it! Instead, all we need to do is:
Build a mechanism that we can easily extend.
Cover the most important use cases.
This PR creates the
MagnitudeLabel
trait mechanism (also accessiblevia a function/value interface as
mag_label
). We enumerate thevarious categories of magnitudes that we can label, defaulting to
"unsupported". The first two supported categories are integers (that
fit in
std::uintmax_t
), and rationals.We also add a trait,
has_exposed_slash
, looking forward to the obvioususe case of auto-generating labels for scaled units. Those labels will
have the form
"[M U]"
for a unit of label"U"
scaled by a magnitudeof label
"M"
. Ifhas_exposed_slash
istrue
for a given magnitudelabel, then we'll know to make this
"[(M) U]"
instead.Finally, we move a couple of
StringConstant
-ish utilities into"string_constant.hh"
, so that we can use them in our implementation.Helps #85.