Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly static cast to long double #267

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

chiphogg
Copy link
Contributor

This fixes a very verbose warning that I noticed when installing the
library in a Visual Studio project on Windows. And it just seems like a
clearly good change for its own sake, anyway.

This fixes a very verbose warning that I noticed when installing the
library in a Visual Studio project on Windows.  And it just seems like a
clearly good change for its own sake, anyway.
@chiphogg chiphogg added the release notes: 🐛 lib (bugfix) PR fixing a defect in the library code label Jul 20, 2024
@chiphogg chiphogg requested a review from geoffviola July 20, 2024 14:57
Copy link
Contributor

@geoffviola geoffviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to add the cast to be explicit.

In a future PR, we should compile with /W4 for Windows. There might be additional warnings that we're missing out on especially when we compile the tests. For example, there are a few in just the single file header: godbolt.

@chiphogg
Copy link
Contributor Author

Kind of amazed that pulling and merging correctly applied this change to the file's new home!

@chiphogg chiphogg merged commit 374221e into main Jul 22, 2024
11 checks passed
@chiphogg chiphogg deleted the chiphogg/static-cast-hi-long-double branch July 22, 2024 14:12
@chiphogg
Copy link
Contributor Author

It makes sense to add the cast to be explicit.

In a future PR, we should compile with /W4 for Windows. There might be additional warnings that we're missing out on especially when we compile the tests. For example, there are a few in just the single file header: godbolt.

Good suggestion! I put up a draft PR (#269). We'll see how the build goes. At any rate, that'll help prevent us from forgetting to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: 🐛 lib (bugfix) PR fixing a defect in the library code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants