Feat: Add EIP-7702 - new type transaction #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrLSD
added
C-enhancement
|
It would be good to add some integration tests/examples which demonstrate the new functionality. |
birchmd
requested changes
Oct 7, 2024
birchmd
reviewed
Oct 8, 2024
There was a problem hiding this comment.
The implementation looks good to me now, nice work. I still think it would be nice to have some integration tests for this feature. I think the following tests would be good to have:
- Happy path: EOA delegates code to a contract and then a transaction to that EOA executes successfully
- Error path: Delegation fails for incorrect nonce
- Error path: Delegation fails for incorrect chain id
- Error path: Delegation fails for invalid signature
| if self.transaction.authorization_list.is_empty() { | ||
| return Err(Error::EmptyAuthorizationList); | ||
| } | ||
| let current_tx_chain_id = U256::from(self.transaction.chain_id); |
There was a problem hiding this comment.
Good idea taking the current chain id from the transaction itself!
engine-tests/src/tests/repro.rs
Outdated
| @@ -88,7 +88,7 @@ fn repro_5bEgfRQ() { | |||
| block_timestamp: 1_651_073_772_931_594_646, | |||
| input_path: "src/tests/res/input_5bEgfRQ.hex", | |||
| evm_gas_used: 6_414_105, | |||
| near_gas_used: 650, | |||
| near_gas_used: 508, | |||
There was a problem hiding this comment.
It's always nice to see the gas costs go down when we move to a newer version of sputnikVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
➡️ Added EIP-7702 - new type transaction for
Praguehard fork➡️ Changed basic EVM transact functions call
aurora-evmtransact functions has breaking changes, wich includes new fields related toEIP-7702.Gas cost
➡️ Gas costs decreased. In some cases significantly.