-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DB Compatibility & small fixes #33
base: main
Are you sure you want to change the base?
Conversation
Wow, thank you so much for the contribution. I may take me some time to look through this code before merging, but it looks really good! I have learnt a lot as this project evolved so I appreciate the clean up and hope the code wasn't too hard to decipher. I know my previous Gorm approach didn't support Postgres, but I learned as I went. Your approach is completely new to me so I will have to learn it for future development. This is preferable though, as I want to support more DB formats. Seems to be this approach: https://gorm.io/docs/advanced_query.html |
Still looking through and debugging on the MariaDB side. Your changes didn't work out of the box. I have fixed some issues while (hopefully) maintaining PostGresSQL support. Now I am stuck at this issue:
That code produces this MYSQL statement:
Which does not include the Honestly I am considering scrapping MariaDB support altogether and migrating to PostGresSQL. |
i rebased my branch on yours to include the few fixes of the last month ;) |
I tried to use Pønskelisten with a postgresql database. It didn't work so i fixed the code so it works now. mysql/mariadb should still work perfectly.
also found some redundant code and small bugs which i fixed :)