-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 - Custom Binding #44
Open
vectrixdevelops
wants to merge
97
commits into
master
Choose a base branch
from
release-2.0-browser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 74 commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
525377f
Move changes to release-2.0 branch
vectrixdevelops 937c85b
Add node-gyp to install in travis
vectrixdevelops 49f1b07
Add mpg123 submodule
vectrixdevelops 0edb96d
Modify gitignore
vectrixdevelops e63ab36
Add windows configurations
vectrixdevelops 2a5a37b
Add Linux config for mpg123
jamen 23ca6f9
Add libasound to .travis.yml
vectrixdevelops 9b83b6d
Add node-gyp to travis script
vectrixdevelops 988ab97
JavaScript Implementation (#24)
vectrixdevelops b896919
Add test and fix most bugs
vectrixdevelops dd4d4c9
Clean up debug messages
vectrixdevelops e401110
Fix write method
vectrixdevelops f21c47d
Fix test message output
vectrixdevelops 9625c5d
Update submodule to 1.23.8
vectrixdevelops 123327c
Add autoFlush option and add end method to test
vectrixdevelops 802cb5a
Delete audio handler on close
vectrixdevelops 17ffb55
Add autoFlush test
vectrixdevelops 960f5e5
Add sink implementation
vectrixdevelops 1f29553
Simplify implementation
vectrixdevelops d1af218
Remove support for node 0.10 and 0.12
vectrixdevelops ceac771
Add streams implementation
vectrixdevelops 02097dc
Add pullstream implementation
vectrixdevelops ad5247a
mac config
whaaaley b385e05
Add usage into readme
vectrixdevelops b463e0b
Add docs to direct
vectrixdevelops 52d54c3
Add docs to pull
vectrixdevelops 2616180
Add docs to stream
vectrixdevelops e1c7bee
Remove remaining param from write publicly
vectrixdevelops a9da5e3
Add browser note
vectrixdevelops 31b832a
Use tape for tests
vectrixdevelops 613e8f9
Replace validate with objectAssign
vectrixdevelops 3e24ec3
Update submodule to fix coreaudio and remove unnecessary compat headers
vectrixdevelops fbcd237
Add browser implementation
vectrixdevelops 280da98
Add mpg123 as an optional dependency
vectrixdevelops 01cc009
Remove node-gyp from travis
vectrixdevelops 2d3c9dd
2.0.0-1
vectrixdevelops ba50a61
Fix package.json
vectrixdevelops 963fb27
2.0.0-2
vectrixdevelops 8a92b61
Change defaults and browser related functions and information
vectrixdevelops de88016
2.0.0-3
vectrixdevelops 675073a
Update audio-mpg123
vectrixdevelops 5cfc9e4
Add latest node version to travis.yml and rename tests
vectrixdevelops 74b887d
Bump audio-mpg123 version
vectrixdevelops a257382
2.0.0-4
vectrixdevelops 37a7449
Add test to travis.yml
vectrixdevelops b76ffa2
Simplify stream.js
dy b488588
Simplify browser includes
dy 0821744
Add node sine test
dy 6f354bd
Fix browser entry
dy f48bbf5
Resurrect classic test-cases
dy 9cfb8d7
Fix some eslints
dy ef06e14
Fix test case
dy 6f8f4c9
Update audio-mpg123 to 1.2.0
vectrixdevelops 8f21d51
Update audio-mpg123 to v1.2.2
ec82b6c
Convert some debugs to errors and update travis
vectrixdevelops 64f6ca8
Update audio-mpg123 to 1.2.3
vectrixdevelops ed3a41f
Add sine test to package scripts
vectrixdevelops 5984b3a
2.0.0-5
vectrixdevelops aca6843
Rename index.js to node.js
jamen e240fee
Change import to browser/node env
jamen d94957d
Add yarn.lock
jamen f35f20f
Fix audio-speaker/browser
jamen e15ba63
Remove pull stream and node stream support (move to another package)
vectrixdevelops 9f17096
Fix up readme
vectrixdevelops 91dacb1
Remove uneeded tests
vectrixdevelops f4c8cf1
Make improvement to test ending
vectrixdevelops 57342ef
Add sine test
vectrixdevelops 7db3a0c
Improve auto flush and add auto flush test
vectrixdevelops 67706d6
Improve example in readme
vectrixdevelops da39399
Update pcm-util
dy 8321ed8
Update test/deps
dy 944f254
Add browser version & test
dy bf6e77c
Clean up
vectrixdevelops c8a5d31
Add callback for abandoned remaining chunks
vectrixdevelops 9f4adea
Fix speaker options assertion
vectrixdevelops a130cb2
Refactor tests
dy b5f1816
Fix browser tests
dy 41a7caa
Fix up use of assertion
vectrixdevelops b746212
Remove assertion
vectrixdevelops 1f60aed
Remove the assertion I didn't see
vectrixdevelops f980a8e
Add temporary test fix
vectrixdevelops 2ca1050
Tidy up end method
vectrixdevelops a75a8cd
Upgrade Node implentation and tests
jamen 3134239
Fix minor things from Node impl and package.json
jamen d8aa826
Fix readme link to audio-speaker-stream
jamen cae0469
Introduce pcm-convert
dy 49339ca
Merge branch 'release-2.0-browser' of github.com:audiojs/audio-speake…
dy 8ff35ae
Fix endianness
dy 394eb4f
Fix buffer creation
dy 51d4f9d
Fix tests
dy 75b92c2
Make test work (yay)
dy 07ca65a
Make tests pass perfectly
dy ddb3592
Fix formal details
dy 09a8f99
Update readme/details
dy d70877b
Simplify inner structure
dy 856d983
Update pcm-convert
dy 4adf45e
Return dtypes
dy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "src/mpg123"] | ||
path = src/mpg123 | ||
url = https://github.com/audiojs/mpg123 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,30 @@ | ||
sudo: false | ||
language: node_js | ||
node_js: | ||
- "node" | ||
- "6" | ||
- "5" | ||
- "4" | ||
- "0.12" | ||
- "0.10" | ||
addons: | ||
apt: | ||
packages: | ||
- libgnome-keyring-dev | ||
- g++-4.8 | ||
- libasound2-dev | ||
sources: | ||
- ubuntu-toolchain-r-test | ||
env: | ||
- CXX=g++-4.8 | ||
install: | ||
- npm install -g npm | ||
- npm install -g node-pre-gyp | ||
- npm install | ||
- cd ./node_modules/audio-mpg123 | ||
- node-pre-gyp clean | ||
- node-pre-gyp rebuild --mpg123-module=dummy | ||
script: | ||
- node -v | ||
- npm -v | ||
- npm run test | ||
matrix: | ||
fast_finish: true | ||
allow_failures: | ||
- node_js: "0.10" | ||
- node_js: "0.12" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Copyright (c) 2016 AudioJS <https://github.com/audiojs> | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/** @module audio-speaker/browser */ | ||
'use strict' | ||
|
||
var objectAssign = require('object-assign') | ||
var createContext = require('audio-context') | ||
var createWriter = require('web-audio-write') | ||
|
||
module.exports = function createSpeaker (opts) { | ||
var options = {} | ||
|
||
options = objectAssign({ | ||
channels: 1, | ||
sampleRate: 44100 | ||
}, opts) | ||
|
||
var ctx = options.context || createContext(options) | ||
var write = createWriter(ctx.destination, options) | ||
|
||
return write | ||
} |
Empty file.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
/** @module audio-speaker */ | ||
'use strict'; | ||
module.exports = require('./direct'); | ||
'use strict' | ||
|
||
module.exports = | ||
require('is-browser') | ||
? require('./browser') | ||
: require('./node') |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want default speaker to have mono output? I'd drop that option, but no worries I will handle that once we are merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, this is the same in node and in the readme. So if you'd like to change that feel free. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would go in line with your recent audio-buffer changes, right? I'm for keeping this. 👍