Read lyrics tag from FLAC, Ogg Vorbis & Opus files #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same tag should also work for Opus files, right? Then please
Thanks. 👍 |
|
all done! I guess in future we'd maybe want to centralize the vorbis comment handling... maybe something for libaudtag? |
radioactiveman
force-pushed
the
patch-1
branch
from
b125d95 to
a00b899
Compare
radioactiveman
changed the title
radioactiveman
merged commit b593bda
into
audacious-media-player:master
8 of 9 checks passed
|
Thanks, merged now. I assume the reason why libaudtag does not include vorbis comment handling is that we don't want to add a hard dependency on libvorbis for audacious-core. Maybe @jlindgren90 can answer this. Another advantage would be trivial support for writing tags to Opus files. Right now it can only read them. |
|
libaudtag predates Opus support, and the FLAC code is a bit different I think (doesn't use libvorbis for the parsing IIRC). So it didn't make sense to commonize at the time libaudtag was created. Maybe it does now, I don't know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for reading lyrics from FLAC & Ogg Vorbis files
I've tested the FLAC support locally, works after you refresh the track (otherwise it has stale cached tuple data, I guess)