Drop UR submodules #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are minor point releases higher than the versions we had been using as submodules. I confirmed that our code builds against the released versions, but we need to check with the real system to ensure that nothing about the driver behavior has changed.
nickswalker
changed the title
|
|
|
Getting these into robostack may require more work on the PR here: RoboStack/ros-noetic#385 |
markusgrotz
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR has since made binary releases of these packages
They are minor point releases higher than the versions we had been using as submodules.
I confirmed that our code builds against the released versions (no changes necessary, as we have the right rosdeps declared), but we need to check with the real system to ensure that nothing about the driver behavior has changed.