feat: support storing, syncing and executing scripts #2644
+1,840
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellie
force-pushed
the
ellie/scripts
branch
3 times, most recently
from
fbebf3c to
8ddfb76
Compare
BinaryMuse
approved these changes
Apr 4, 2025
| } | ||
|
|
||
| // Add the script path | ||
| cmd.arg(temp_path.to_str().unwrap()); |
There was a problem hiding this comment.
Do we need to remove the shebang from the file in this case, since we're executing it directly with the interpreter?
Comment on lines
+19
to
+20
| #[arg(short, long)] | ||
| pub name: String, |
There was a problem hiding this comment.
Thoughts on allowing this to be positional? The other commands that take a script name do so, and it's a required parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #2552
The goal with this PR is to have a totally non-interactive setup. Doesn't really make the most of the rest of the data we have ;)
Follow up with the ability to build scripts via the search tui
Checks