Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sql files checksums #2601

Merged
merged 2 commits into from
Mar 3, 2025
Merged

fix: sql files checksums #2601

merged 2 commits into from
Mar 3, 2025

Conversation

ltrzesniewski
Copy link
Contributor

Checking out on Windows may cause *.sql files to have CRLF line endings, which will change their checksums and cause migration errors.

Works around launchbadge/sqlx#2659

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Checking out on Windows may cause *.sql files to have CRLF line endings, which will change their checksums and cause migration errors.

launchbadge/sqlx#2659
@ltrzesniewski ltrzesniewski mentioned this pull request Mar 2, 2025
2 tasks
@ltrzesniewski
Copy link
Contributor Author

I also added shell scripts to .gitattributes since include_str! doesn't normalize to LF.

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thank you!

@ellie ellie merged commit 5bffda6 into atuinsh:main Mar 3, 2025
19 checks passed
@ltrzesniewski ltrzesniewski deleted the fix-migrations branch March 3, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants