correction initialize args and comprehention constructions #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ArtemIsmagilov
commented
Jul 15, 2024
ArtemIsmagilov
commented
- create generator comprehention, lazy object
- remove dangerous pass mut args in func initialize, removed overwriting args
- create list comprehention, high perfomance
2. remove dangerous pass mut args in func initialize, removed overwriting args 3. create list comprehention, high perfomance
unode
reviewed
Jul 19, 2024
mmpy_bot/driver.py
Outdated
| @@ -160,14 +160,15 @@ def direct_message( | |||
| message: str, | |||
| file_paths: Optional[Sequence[str]] = None, | |||
| root_id: str = "", | |||
| props: Dict = {}, | |||
| props: Dict = None, | |||
There was a problem hiding this comment.
Same as above, won't type-check.
mmpy_bot/driver.py
Outdated
| @@ -116,7 +116,7 @@ def reply_to( | |||
| message: Message, | |||
| response: str, | |||
| file_paths: Optional[Sequence[str]] = None, | |||
| props: Dict = {}, | |||
| props: Dict = None, | |||
There was a problem hiding this comment.
Same as above, won't type-check.
mmpy_bot/driver.py
Outdated
| @@ -43,7 +43,7 @@ def create_post( | |||
| message: str, | |||
| file_paths: Optional[Sequence[str]] = None, | |||
| root_id: str = "", | |||
| props: Dict = {}, | |||
| props: Dict = None, | |||
|
Code Climate has analyzed commit 78b613e and detected 0 issues on this pull request. View more on Code Climate. |
ArtemIsmagilov
commented
Jul 19, 2024
| @@ -34,7 +34,7 @@ def expect_reply(driver: Driver, post: Dict, wait=RESPONSE_TIMEOUT, retries=1): | |||
| reply = thread_info["posts"][reply_id] | |||
| break | |||
|
|
|||
| if not reply: | |||
| if reply is None: | |||
There was a problem hiding this comment.
boolean 0 will be false
attzonko
pushed a commit
that referenced
this pull request
Dec 11, 2024
1. create generator comprehension, lazy object 2. remove dangerous pass mut args in func initialize, removed overwriting args 3. create list comprehension, high performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.