Block ERC721 transfers #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for your work here, I really appreciate it. I originally planned to make a bigger change on the main branch but then focused on something else. Anyways, my original plan had included using https://github.com/attestate/ERC5192 as this would then also encapsulate the blocking and its details in that standard. The plan was also to make the changes to the specification in that regard. Would you be up to do that? I‘m happy to assist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block the transfers of ERC721:
transferFrom(address,address,uint256)safeTransferFrom(address,address,uint256)safeTransferFrom(address,address,uint256,bytes)Use
_transferinstead oftransferFromAnd add transfer test