Skip to content

Conversation

@wt
Copy link
Contributor

@wt wt commented Nov 12, 2025

This crate needs to be the same as the atsamd-hal, which uses version 0.3.2.

Summary

I updated the usb-device dependency of the feather_m0 support crate to match the version used in atsamd-hal.

Checklist

  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

This crate needs to be the same as the atsamd-hal, which uses
version 0.3.2.
@rnd-ash
Copy link
Contributor

rnd-ash commented Nov 17, 2025

Why would this be necessary? Cargo should auto-pull the latest patch version of any dependency...or did USB-Device break the API in a patch version?

@jbeaurivage
Copy link
Contributor

Why would this be necessary? Cargo should auto-pull the latest patch version of any dependency...or did USB-Device break the API in a patch version?

Yeah, I have this question as well

@wt
Copy link
Contributor Author

wt commented Nov 17, 2025

When I was building stuff I saw warnings about different versions of deps in the dependency tree. It might be better to make the dev deps for the examples use a * version for most of their deps, I think they would then just match whatever is used in other parts of the dep tree.

Again, I was just trying to get rid of the warning. I know rust will not see the data structures from different versions of crates as different. I just figured that probably wasn't good for binary size.

@rnd-ash
Copy link
Contributor

rnd-ash commented Nov 18, 2025

@wt if you run cargo update from within your project, it should pull the latest patch versions of every dependency in the tree.

Out of interest, what kind of warnings do you get? - I haven't seen warnings before related to different crate versions...

@wt
Copy link
Contributor Author

wt commented Nov 18, 2025

I was matching the dep from the hal crate's Cargo.toml:

usb-device = {version = "0.3.2", optional = true}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants