-
Notifications
You must be signed in to change notification settings - Fork 217
bsp: Add defmt feature #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
392b874 to
80135bd
Compare
|
Great idea with the build.rs! |
|
|
bd17e3b to
e0ec140
Compare
|
@ianrrees is there something specific you'd like me to look at? I don't use a debugger or |
Nothing specific, just noticed that git blame showed you as touching some lines to do with |
|
@ianrrees I did not see this in the git blame, though I have never used that command before until now. I did touch lines related to the |
e0ec140 to
a2ee483
Compare
|
@ianrrees I can't find anything wrong with this PR that might need correcting, it all looks good. Potentially, yes, using RTT Serial and DEFMT could cause issues if used together, I might be able to test this later today and check |
This adds a
defmtfeature to our T1 BSPs (plus Grand Central M4, as groundwork for @supersimple33 's #902) which enables the HAL'sdefmtfeature and sets the linker argument usingbuild.rs.I'm a little surprised this seems compatible with the
use_rttfeature, inasmuch as the examples still build. @kyp44 if you have a minute, could you please have a look and see if this looks problematic?Resolves #810