Use type-level programming instead of macros for adc
#616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `adc` modules use macros to be generic over the ADC peripheral. Update the code to use type-level programming techniques instead, but do so in a backwards-compatible way.
bradleyharden
force-pushed
the
remove_adc_macros
branch
from
f3f8809
to
1bf7568
Compare
bradleyharden
commented
May 30, 2022
| } | ||
|
|
||
| macro_rules! adc_pins { | ||
| ( | ||
| $( | ||
| $PinId:ident: ($ADC:ident, $CHAN:literal), | ||
| $PinId:ident: [ $( ($ADC:ident, $CHAN:literal) ),+ ], |
There was a problem hiding this comment.
I made this a list of tuples rather than a single tuple, because some pins can be an input for both ADC0 and ADC1. We should update the pin table below to match the datasheet. It's missing a bunch of entries right now.
|
If you want to get more aggressive with the refactor, I see a lot of areas where this module could be cleaned up and simplified. But for now, I wanted to keep everything backwards-compatible. |
|
@wembly, it sounds like you were able to get something working for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
adcmodules use macros to be generic over the ADCperipheral. Update the code to use type-level programming techniques
instead, but do so in a backwards-compatible way.
Checklist
CHANGELOG.mdfor the BSP or HAL updated