Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get ready for v0.13 release #462

Merged
merged 15 commits into from
Sep 27, 2021
Merged

Get ready for v0.13 release #462

merged 15 commits into from
Sep 27, 2021

Conversation

jbeaurivage
Copy link
Contributor

@jbeaurivage jbeaurivage commented Jun 28, 2021 •
edited by bradleyharden
Loading

This PR aims to tie some loose ends before pushing the v0.13 release:

  • Add changelog. This should be updated in the future as individual PRs get merged
  • Add deprecation notices to modules that exist solely for backwards compatibility
  • Add deprecation notice to gpio::v1
  • Add deprecation notice to sercom::v1::{spi, uart}
  • Carry out whatever decision is made regarding Tier 1 vs Tier 2 BSPs and add an explanation to the README
  • Update all Tier 1 BSPs to v2 modules:
  • Tie all Tier 2 BSPs' atsamd-hal dependency to crates.io
  • Manually bump T2 BSPs (GHA workflow only bumps T1 boards)
  • Bump T1 BSP and PAC versions using GHA workflow (HAL is already bumped)
  • Release to crates.io and tag commit with v0.13.0

@jbeaurivage jbeaurivage mentioned this pull request Aug 9, 2021
Closed
@jbeaurivage jbeaurivage force-pushed the release-v0.13 branch 7 times, most recently from c23294d to 90ea7bd Compare August 11, 2021 21:05
@jbeaurivage
Copy link
Contributor Author

I've changed the atsamd-hal dependency to crates.io for all Tier 2 BSPs. Now obviously these will all fail CI until a 0.13 version is actually published to crates.io

@sajattack
Copy link
Member

I've changed the atsamd-hal dependency to crates.io for all Tier 2 BSPs. Now obviously these will all fail CI until a 0.13 version is actually published to crates.io

I typically update the version numbers and publish at the same time, no biggie though.

@jbeaurivage
Copy link
Contributor Author

I typically update the version numbers and publish at the same time, no biggie though.

That's probably a good idea. I think the PAC versions should also get bumped since we've had SVD patches since 0.12

@sajattack
Copy link
Member

I typically update the version numbers and publish at the same time, no biggie though.

That's probably a good idea. I think the PAC versions should also get bumped since we've had SVD patches since 0.12

yep

@jbeaurivage jbeaurivage force-pushed the release-v0.13 branch 6 times, most recently from 5babe9a to c32a17f Compare August 15, 2021 20:53
@jbeaurivage
Copy link
Contributor Author

@sajattack, @twitchyliquid64: @bradleyharden brought this to my attention: Now that Tier 2 BSPs will be tied to the crates.io version of atsamd-hal, it seems exceedingly wasteful to run CI checks to these boards all the time. It would instead make more sense to only check that the Tier 2 BSP+examples compile when they are actually changed. Is this something with which can get GHA to play nice?

@twitchyliquid64
Copy link
Contributor

As an open-source project doing actual CI we have unlimited quota here, so we don't have to be cautious with our use of CI.

That said, if you want to do this, we can do this pretty easily as long as crates.json captures the tier status of each BSP.

@jbeaurivage jbeaurivage force-pushed the release-v0.13 branch 3 times, most recently from 66daf51 to 9b1a799 Compare August 16, 2021 00:49
@jbeaurivage
Copy link
Contributor Author

As discussed on Matrix, we could pull the trigger on a release even though not all T1 boards have been updated yet - We would need to upgrade them before the v0.14 release.

@bradleyharden bradleyharden mentioned this pull request Sep 8, 2021
Open
@jbeaurivage jbeaurivage force-pushed the release-v0.13 branch 3 times, most recently from 7260a25 to 503cbb2 Compare September 9, 2021 13:28
@jbeaurivage jbeaurivage mentioned this pull request Sep 9, 2021
Closed
8 tasks
@bradleyharden
Copy link
Contributor

This is good to go, I think. If anyone wants to jump in and handle the last steps, go for it. Otherwise I'll try to figure it out soon

@TDHolmes
Copy link
Contributor

feather_m4 update

@jbeaurivage jbeaurivage merged commit 0359814 into atsamd-rs:master Sep 27, 2021
kaizensparc pushed a commit to kaizensparc/atsamd that referenced this pull request Dec 24, 2021
@jbeaurivage
Get ready for v0.13 release (atsamd-rs#462)
5fa9e19 
* Add changelog

* Add deprecation notices in lib.rs

* Add deprecation notices to common and samd/same modules in lib.rs

* Add deprecation notice to gpio::v1

* Add deprecation notices for sercom::v1::{spi, uart}

* Add BPS tiers to README

* Deprecate spi_common module

* Update samd11_bare to v2 APIs

* Deprecate SpinTimer

* Update metro_m0 to uart::v2

* Deprecate atsamd_hal::hal and atsamd_hal::target_device

* Tie T2 boards to crates.io atsamd-hal dependency

* Tie all BSPs to atsamd-hal = 0.13

* Bump atsamd-hal to 0.13

* Bump T2 BSP versions
@jbeaurivage jbeaurivage deleted the release-v0.13 branch February 9, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbeaurivage @sajattack @twitchyliquid64 @bradleyharden @TDHolmes