SETUPVAL addition? #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we start. You need to know that I have no clue about this Registers or Instructions stuff. I am literally learning but I barely have any good resources to understand nor comprehend easily on what is going on and need a little bit of help or time.
Bytecode input file used: https://github.com/MaximumADHD/Roblox-Client-Tracker/blob/79d958e1c5e9acff1f1a053873852d7c3a682b16/BuiltInPlugins/AnimationClipEditor/Src/Util/TrackSelectionUtils.luac
It's old unlua'd version: https://github.com/MaximumADHD/Roblox-Client-Tracker/blob/79d958e1c5e9acff1f1a053873852d7c3a682b16/BuiltInPlugins/AnimationClipEditor/Src/Util/TrackSelectionUtils.unluau.lua
The differences.
https://www.diffchecker.com/6FkhJrok/
Input 2:
https://github.com/MaximumADHD/Roblox-Client-Tracker/blob/79d958e1c5e9acff1f1a053873852d7c3a682b16/BuiltInPlugins/AnimationClipEditor/Bin/main.luac
(note this one will error if you don't comment out the error)
hence, get rid of this, if you want to understand how I used this Bytecode input as a demonstration.
https://www.diffchecker.com/NuhFmZdx/
This is how the differences look like with both of my "patches" applied.
https://www.diffchecker.com/oEnOdmc1/