Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI: API renames #696

Merged
merged 3 commits into from
Dec 16, 2023
Merged

SPI: API renames #696

merged 3 commits into from
Dec 16, 2023

Conversation

bettio
Copy link
Collaborator

@bettio bettio commented Jul 22, 2023

Make names shorter and clearer, with no additional clutter.

Closes #651

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@bettio bettio force-pushed the spi-api-renames branch 2 times, most recently from 16d2d41 to 8eb9ef9 Compare July 22, 2023 17:31
@bettio bettio added this to the v0.6 milestone Jul 28, 2023
@bettio bettio removed the blocking label Aug 6, 2023
Copy link
Collaborator

@fadushin fadushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure all the deprecated atoms are accounted for in the code, and I think we need to correct or update the documentation and UPDATING.md with this.

@bettio bettio force-pushed the spi-api-renames branch 4 times, most recently from ccab726 to 25b5da1 Compare December 15, 2023 00:45
@bettio bettio marked this pull request as ready for review December 15, 2023 00:46
In order to provide some compatibility deprecated map entries are
translated, such as `miso_io_num` to `miso` and a warning is printed.

Signed-off-by: Davide Bettio <[email protected]>
Add support to alternatives to `mosi` and `miso` as described in
https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/ .

Signed-off-by: Davide Bettio <[email protected]>
@bettio bettio merged commit 2cc65f7 into atomvm:master Dec 16, 2023
78 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SPI naming and consistency
2 participants