Add lists:append/1 and lists:append/2.

[migmatore]

These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

[bettio]

The change looked legit, but somehow CI is failing.

[UncleGrumpy]

I left a comment in the code where the documentation is failing to build.

[UncleGrumpy]

There are a couple mistakes in the tests.

[migmatore]

Looks like I fixed everything. Waiting for CI.

[UncleGrumpy]

It was only the second exception that needed to be changed.

[migmatore]

It looks like I still have to remove ?ASSERT_ERROR(lists:append(1, 3), badarg) or add the lists:append/2 function to successfully complete CI.

[UncleGrumpy]

It looks like you found a discrepancy between AtomVM an OTP. Your test now passes on the BEAM, but fails on AtomVM. OTP is raising a badarg for lists:append(1, 3) but AtomVM is raising undef.

[migmatore]

I'll try adding lists:append/2 to this commit, I think it will fix it. Because it looks like BEAM gives badarg error, since the append/2 function is implemented there.

[UncleGrumpy]

I'll try adding lists:append/2 to this commit, I think it will fix it. Because it looks like BEAM gives badarg error, since the append/2 function is implemented there.

Good catch, I should have realized that was the difference here. You could check the return conditionality based on the return of erlang:system_info(machine). OTP will return "BEAM" and AtomVM will return "ATOM".

[UncleGrumpy]

But lists:append/2 might be a good compliment to this addition anyway.

[migmatore]

I also think I need to add these functions to List.ex? And maybe the elixir files should be named using snake_case, right? Well, at least that's what the elixir documentation says about Naming conventions, although it's not necessary. If there is an opportunity and there are no restrictions, I could do it.

[UncleGrumpy]

Nice. Those last few tests that failed and not related to your changes. This looks ready to merge.

[UncleGrumpy]

I also think I need to add these functions to List.ex? And maybe the elixir files should be named using snake_case, right? Well, at least that's what the elixir documentation says about Naming conventions, although it's not necessary. If there is an opportunity and there are no restrictions, I could do it.

As far as I can tell Elixir does not have List.append/1,2, I think this is normally accomplished with ++, but regardless, it can be left for a future PR.

[migmatore]

As far as I can tell Elixir does not have List.append/1,2, I think this is normally accomplished with ++, but regardless, it can be left for a future PR.

Yes, exactly... for some reason it seemed to me that there are such functions, but okay :)