Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix +/1 (unary plus) not implemented #1512 #1545

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

migmatore
Copy link
Contributor

These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Copy link
Collaborator

@pguyot pguyot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution.

@migmatore migmatore force-pushed the impl_unary_plus branch 3 times, most recently from e033a0c to 12a9bf2 Compare February 16, 2025 19:07
@migmatore migmatore requested a review from pguyot February 16, 2025 19:11
@migmatore
Copy link
Contributor Author

Should I add information about this in CHANGELOG.md?

Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor changes + let's add it to Unreleased / Added changelog section.
Last but not least, let's squash it to a single commit.

@migmatore migmatore force-pushed the impl_unary_plus branch 3 times, most recently from 54f67d7 to 65a8b46 Compare February 16, 2025 20:24
@migmatore migmatore requested a review from bettio February 16, 2025 20:25
Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments. I will merge this PR after CI turns green.

Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed.
Please, use rebar3 fmt -w in order to format your source.
We are using erlfmt.

These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Signed-off-by: migmatore <[email protected]>
@bettio bettio merged commit 7caa566 into atomvm:main Feb 17, 2025
108 of 110 checks passed
@migmatore migmatore deleted the impl_unary_plus branch February 17, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants