This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
Contributor
Author
|
This introduces a lot of native crashes for me, which is concerning because it only touches JavaScript. I haven't been able to figure out why, though: I'm seeing different crashes when I change any of the logging or run under WinDbg, and I can't seem to replicate without this commit.
I'm going to leave this unresolved for now and see how we're doing on Linux, and have another look post-:baby:. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a directory is watched on Windows, implicitly create non-recursive watchers the whole way up the directory tree to the drive root. When any directory along the way is removed or renamed, emit a synthetic
{ "action": "removed", "kind": "directory", "path": "/root" }event for the watch root and uninstall it.