This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Update nan #63
Open
Update nan #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: I was using the wrong version of node. Verified by https://github.com/icecream17/atom/tree/electron-17 (note: commit message is wrong, there's still some bootstrap errors) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 👋
I am not using any of the templates for the PR because this one doesn't really fall into any of those categories 🤔
Essentially I'm trying to do some investigations to get Atom working with a later version of Electron and I came across this package when trying to build.
It would seem that trying to build on a more recent node version I'm hitting an issue that was fixed in version 2.14.1 of nan
Let me know if you have any questions 👍