Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

fix: false-positive error 'ts server not found' if project wasn't open #166

Merged

Conversation

vlad0337187
Copy link

Requirements for Contributing a Bug Fix

Identify the Bug

Didn't create new issue, because this is realted to changes, made in: #154
If to open project without locally specified TS server path, it will show error alert.
Also if to open project with locally specified TS server path, it'll show error alert anyway, because project path is not always set.

Description of the Change

Just check that path doesn't exist and do nothing.
Also did a little refactor for already added code.

Alternate Designs

just a fix

Possible Drawbacks

Didn't find such, use this fix locally for near one month.

Verification Process

Use this plugin with my typescript project near one month.

Release Notes

@vlad0337187
Copy link
Author

Fixed found caused by recent PR issue.
If anybody will have some time to review and merge - would be grateful =)

@Aerijo
@damieng
@darangi
@jasonrudolph
@dmleong
@daviwil

@vlad0337187 vlad0337187 force-pushed the fix/false-positive-ts-server-not-found branch from 9b60b9d to 51040b4 Compare September 28, 2021 22:43
@vlad0337187
Copy link
Author

Sorry for pinging about this. Just wanna leave a notification.

@Aerijo
@damieng
@darangi
@jasonrudolph
@dmleong
@daviwil

@damieng
Copy link
Contributor

damieng commented Sep 29, 2021

Please stop "pinging" everybody who ever contributed to this repo. This project was discontinued by github and most of the people on your list are no longer involved or have access.

Darangi is seemingly the only active contributor. If they can respond they will.

@darangi
Copy link
Contributor

darangi commented Sep 29, 2021

@vlad0337187 Thanks for the contributions 🙇🏾

@darangi darangi merged commit d0992b9 into atom:master Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants