Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Bump TSServer & Theia Version #160

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

mattlyons0
Copy link
Contributor

New versions of TSServer when paired with Theia's language server include some very useful features (most notably it now seems to download types for node packages in the background now).

I've tested this throughout various JS repos and have not noticed any regressions.

The reason for the Theia (typescript-language-server) semvar major bump is because the package bumped monaco-languageclient which now is written in ES6.

Old:

image

image

New:

image

This fixes #158.
This affects #144 by making its impact less widespread (any package with typings will no longer show the warning).

@eaviles
Copy link

eaviles commented Dec 12, 2019

@damieng, @50Wliu, would love to have this one out soon. I see errors in Node.js that I don't see in VSCode that would be solved with this PR.

@FDiskas
Copy link

FDiskas commented Jun 12, 2020

And what are you waiting for?

@FDiskas
Copy link

FDiskas commented Jun 12, 2020

And also why not to use project based typescript version?

@damieng
Copy link
Contributor

damieng commented Jun 12, 2020

I left GitHub over two years ago and stopped working on Atom and Atom IDE. While I can no longer speak for GitHub I think the fact they announced they were ceasing work on Atom IDE at the end of 2018 and there's not been any activity at all on this repo in over a year should tell you why.

@bennypowers
Copy link

@damieng I understand that you're not involved with atom development at the moment. Is there anyone else you can pass the baton to? There are still plenty of Atom users who would love to see this relatively straightforward PR land and release.

@icecream17
Copy link

icecream17 commented Apr 12, 2021

pinging @darangi (sorry if i'm pinging too much. - No one at https://github.com/atom/ide-typescript/graphs/contributors contributes to atom today, but since you're under https://github.com/orgs/atom/people you probably have access to merge this pr)

@damieng
Copy link
Contributor

damieng commented Apr 13, 2021

@icecream17 there is an alternative community-maintained package over at https://github.com/atom-community/atom-ide-javascript you might have more success with.

@darangi darangi merged commit d814bcf into atom:master Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade typescript version to support new language features
7 participants