This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Convert to custom Suggestion type & filter text with filterText
key
#262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the internal uses of
ac.AnySuggestion
to the newSuggestion
, which is an extended version of the original. In particular, it has the propertyfilterText
, used for custom filtering. It also makes it easier to add features, such as the replacement prefix tracking in #254Regarding filtering using
filterText
, it seems not even VS Code had a solid idea on the difference betweenfilterText
andsortText
for a timeThe latest I could find is in that last issue, where they say [paraphrasing] "use sort text for no prefix" and "use filterText for when there's a prefix" (and they base on other things like match index). The source code also supports using
filterText
to sort as well when there's a prefix.