Consolidate Router component #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertogasparin
force-pushed
the
tweak/cleanup-routers
branch
2 times, most recently
from
da5cb34
to
07c0721
Compare
albertogasparin
force-pushed
the
tweak/cleanup-routers
branch
from
07c0721
to
6dabf84
Compare
liamqma
reviewed
Apr 2, 2022
liamqma
previously approved these changes
Apr 2, 2022
Co-authored-by: Liam Ma <[email protected]>
liamqma
approved these changes
Apr 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have 4 router components, for no particular reason. They indeed support different features as they have been poorly updated across evolution. This is an initial step toward simplification.
Notable changes:
UniversalRouterandStaticRouter.Routernow does what they did, passing the same propsMemoryRouteris now forced local, as persisted state cause more trouble than anything in testsisStaticprop is gone, we detect node to skipisBrowserOnlyresources