feat: parameterize the fields

atlanhq · Nov 8, 2024 · aafc251 · aafc251
1 parent 06322d3
commit aafc251
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/common/src/main/java/org/apache/atlas/service/redis/AbstractRedisService.java b/common/src/main/java/org/apache/atlas/service/redis/AbstractRedisService.java
@@ -1,6 +1,7 @@
 package org.apache.atlas.service.redis;
 
 import org.apache.atlas.ApplicationProperties;
+import org.apache.atlas.AtlasConfiguration;
 import org.apache.atlas.AtlasException;
 import org.apache.commons.configuration.Configuration;
 import org.apache.commons.lang.ArrayUtils;
@@ -133,10 +134,10 @@ Config getProdConfig() throws AtlasException {
                 .setReadMode(ReadMode.MASTER_SLAVE)
                 .setCheckSentinelsList(false)
                 .setKeepAlive(true)
-                .setMasterConnectionMinimumIdleSize(2)
-                .setMasterConnectionPoolSize(5)
-                .setSlaveConnectionMinimumIdleSize(2)
-                .setSlaveConnectionPoolSize(5)
+                .setMasterConnectionMinimumIdleSize(AtlasConfiguration.ATLAS_REDIS_POOL_CONNECTION_MIN.getInt())
+                .setMasterConnectionPoolSize(AtlasConfiguration.ATLAS_REDIS_POOL_CONNECTION_MAX.getInt())
+                .setSlaveConnectionMinimumIdleSize(AtlasConfiguration.ATLAS_REDIS_POOL_CONNECTION_MIN.getInt())
+                .setSlaveConnectionPoolSize(AtlasConfiguration.ATLAS_REDIS_POOL_CONNECTION_MAX.getInt())
                 .setMasterName(atlasConfig.getString(ATLAS_REDIS_MASTER_NAME))
                 .addSentinelAddress(formatUrls(atlasConfig.getStringArray(ATLAS_REDIS_SENTINEL_URLS)))
                 .setUsername(atlasConfig.getString(ATLAS_REDIS_USERNAME))
@@ -151,10 +152,10 @@ Config getCacheImplConfig() {
                 .setReadMode(ReadMode.MASTER_SLAVE)
                 .setCheckSentinelsList(false)
                 .setKeepAlive(true)
-                .setMasterConnectionMinimumIdleSize(10)
-                .setMasterConnectionPoolSize(2)
-                .setSlaveConnectionMinimumIdleSize(10)
-                .setSlaveConnectionPoolSize(2)
+                .setMasterConnectionMinimumIdleSize(AtlasConfiguration.ATLAS_REDIS_POOL_CONNECTION_MIN.getInt())
+                .setMasterConnectionPoolSize(AtlasConfiguration.ATLAS_REDIS_POOL_CONNECTION_MAX.getInt())
+                .setSlaveConnectionMinimumIdleSize(AtlasConfiguration.ATLAS_REDIS_POOL_CONNECTION_MIN.getInt())
+                .setSlaveConnectionPoolSize(AtlasConfiguration.ATLAS_REDIS_POOL_CONNECTION_MAX.getInt())
                 .setMasterName(atlasConfig.getString(ATLAS_REDIS_MASTER_NAME))
                 .addSentinelAddress(formatUrls(atlasConfig.getStringArray(ATLAS_REDIS_SENTINEL_URLS)))
                 .setUsername(atlasConfig.getString(ATLAS_REDIS_USERNAME))

diff --git a/intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b/intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
@@ -116,7 +116,9 @@ public enum AtlasConfiguration {
 
     ATLAS_MAINTENANCE_MODE("atlas.maintenance.mode", false),
 
-    ATLAS_UD_RELATIONSHIPS_MAX_COUNT("atlas.ud.relationship.max.count", 100);
+    ATLAS_UD_RELATIONSHIPS_MAX_COUNT("atlas.ud.relationship.max.count", 100),
+    ATLAS_REDIS_POOL_CONNECTION_MAX("atlas.redis.connection.max", 5),
+    ATLAS_REDIS_POOL_CONNECTION_MIN("atlas.redis.connection.min", 2);
 
 
     private static final Configuration APPLICATION_PROPERTIES;