Merge pull request #2343 from atlanhq/PLT-1879

PLT-1879: added options to enable method level observability metrics
atlanhq · Sep 4, 2023 · 712a39b · 712a39b
2 parents 8763d1a + 2fd5d4a
commit 712a39b
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/common/src/main/java/org/apache/atlas/service/metrics/MetricsRegistryServiceImpl.java b/common/src/main/java/org/apache/atlas/service/metrics/MetricsRegistryServiceImpl.java
@@ -46,16 +46,16 @@ public void collect(String requestId, AtlasPerfMetrics metrics) {
             if (!ApplicationProperties.get().getBoolean(METHOD_LEVEL_METRICS_ENABLE, false)) {
                 return;
             }
+
+            for (String name : this.filteredMethods) {
+                AtlasPerfMetrics.Metric metric = metrics.getMetric(name);
+                Timer.builder(METHOD_DIST_SUMMARY).tags(Tags.of(NAME, metric.getName())).publishPercentiles(PERCENTILES)
+                        .register(getMeterRegistry()).record(metric.getTotalTimeMSecs(), TimeUnit.MILLISECONDS);
+            }
         } catch (AtlasException e) {
             LOG.error("Failed to read {} property from atlas config", METHOD_LEVEL_METRICS_ENABLE, e);
             return;
         }
-
-        for (String name : this.filteredMethods) {
-            AtlasPerfMetrics.Metric metric = metrics.getMetric(name);
-            Timer.builder(METHOD_DIST_SUMMARY).tags(Tags.of(NAME, metric.getName())).publishPercentiles(PERCENTILES)
-                    .register(getMeterRegistry()).record(metric.getTotalTimeMSecs(), TimeUnit.MILLISECONDS);
-        }
     }
 
     @Override