forked from apache/atlas
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2243 from atlanhq/gov-1233
[master] GOV-1233 Readme/Link CRUD Governance issue
- Loading branch information
Showing
6 changed files
with
315 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
140 changes: 140 additions & 0 deletions
140
...e/atlas/repository/store/graph/v2/preprocessor/resource/AbstractResourcePreProcessor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.atlas.repository.store.graph.v2.preprocessor.resource; | ||
|
|
||
| import org.apache.atlas.RequestContext; | ||
| import org.apache.atlas.authorize.AtlasAuthorizationUtils; | ||
| import org.apache.atlas.authorize.AtlasEntityAccessRequest; | ||
| import org.apache.atlas.authorize.AtlasPrivilege; | ||
| import org.apache.atlas.exception.AtlasBaseException; | ||
| import org.apache.atlas.model.instance.AtlasEntity; | ||
| import org.apache.atlas.model.instance.AtlasEntityHeader; | ||
| import org.apache.atlas.model.instance.AtlasObjectId; | ||
| import org.apache.atlas.repository.graphdb.AtlasEdgeDirection; | ||
| import org.apache.atlas.repository.graphdb.AtlasVertex; | ||
| import org.apache.atlas.repository.store.graph.v2.EntityGraphRetriever; | ||
| import org.apache.atlas.repository.store.graph.v2.preprocessor.PreProcessor; | ||
| import org.apache.atlas.type.AtlasTypeRegistry; | ||
| import org.apache.atlas.utils.AtlasPerfMetrics; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import java.util.Iterator; | ||
|
|
||
| import static org.apache.atlas.repository.Constants.ACTIVE_STATE_VALUE; | ||
| import static org.apache.atlas.repository.Constants.ASSET_RELATION_ATTR; | ||
| import static org.apache.atlas.repository.Constants.STATE_PROPERTY_KEY; | ||
|
|
||
| public abstract class AbstractResourcePreProcessor implements PreProcessor { | ||
| private static final Logger LOG = LoggerFactory.getLogger(AbstractResourcePreProcessor.class); | ||
|
|
||
| private final AtlasTypeRegistry typeRegistry; | ||
| private final EntityGraphRetriever entityRetriever; | ||
|
|
||
| AbstractResourcePreProcessor(AtlasTypeRegistry typeRegistry, | ||
| EntityGraphRetriever entityRetriever) { | ||
| this.typeRegistry = typeRegistry; | ||
| this.entityRetriever = entityRetriever; | ||
| } | ||
|
|
||
| void authorizeResourceUpdate(AtlasEntity resourceEntity, AtlasVertex ResourceVertex, String edgeLabel) throws AtlasBaseException { | ||
| AtlasPerfMetrics.MetricRecorder metricRecorder = RequestContext.get().startMetricRecord("authorizeResourceUpdate"); | ||
|
|
||
| try { | ||
| AtlasEntityHeader assetEntity = null; | ||
|
|
||
| AtlasObjectId asset = getAssetRelationAttr(resourceEntity); | ||
| if (asset != null) { | ||
| //Found linked asset in payload | ||
| AtlasVertex assetVertex = entityRetriever.getEntityVertex(asset); | ||
| assetEntity = entityRetriever.toAtlasEntityHeader(assetVertex); | ||
|
|
||
| } else { | ||
| //Check for linked asset in store | ||
| Iterator atlasVertexIterator = ResourceVertex.query() | ||
| .direction(AtlasEdgeDirection.IN) | ||
| .label(edgeLabel) | ||
| .has(STATE_PROPERTY_KEY, ACTIVE_STATE_VALUE) | ||
| .vertices() | ||
| .iterator(); | ||
|
|
||
| if (atlasVertexIterator.hasNext()) { | ||
| //Found linked asset in store | ||
| AtlasVertex assetVertex = (AtlasVertex) atlasVertexIterator.next(); | ||
| assetEntity = entityRetriever.toAtlasEntityHeader(assetVertex); | ||
| } | ||
| } | ||
|
|
||
| if (assetEntity != null) { | ||
| //First authorize entity update access | ||
| verifyAssetAccess(assetEntity, AtlasPrivilege.ENTITY_UPDATE, resourceEntity, AtlasPrivilege.ENTITY_UPDATE); | ||
| } else { | ||
| //No linked asset to the Resource, check for resource update permission | ||
| verifyAccess(resourceEntity, AtlasPrivilege.ENTITY_UPDATE); | ||
| } | ||
|
|
||
| } finally { | ||
| RequestContext.get().endMetricRecord(metricRecorder); | ||
| } | ||
| } | ||
|
|
||
| void authorizeResourceDelete(AtlasVertex resourceVertex) throws AtlasBaseException { | ||
| AtlasPerfMetrics.MetricRecorder recorder = RequestContext.get().startMetricRecord("authorizeResourceDelete"); | ||
|
|
||
| try { | ||
| AtlasEntity resourceEntity = entityRetriever.toAtlasEntity(resourceVertex); | ||
|
|
||
| AtlasObjectId asset = getAssetRelationAttr(resourceEntity); | ||
| if (asset != null) { | ||
| AtlasEntityHeader assetEntity = entityRetriever.toAtlasEntityHeader(asset.getGuid()); | ||
| verifyAssetAccess(assetEntity, AtlasPrivilege.ENTITY_UPDATE, resourceEntity, AtlasPrivilege.ENTITY_DELETE); | ||
| } else { | ||
| //No linked asset to the Resource, check for resource delete permission | ||
| verifyAccess(resourceEntity, AtlasPrivilege.ENTITY_DELETE); | ||
| } | ||
| } finally { | ||
| RequestContext.get().endMetricRecord(recorder); | ||
| } | ||
| } | ||
|
|
||
| private AtlasObjectId getAssetRelationAttr(AtlasEntity entity) { | ||
| AtlasObjectId ret = null; | ||
|
|
||
| if (entity.hasRelationshipAttribute(ASSET_RELATION_ATTR) && | ||
| entity.getRelationshipAttribute(ASSET_RELATION_ATTR) != null) { | ||
| ret = (AtlasObjectId) entity.getRelationshipAttribute(ASSET_RELATION_ATTR); | ||
| } | ||
|
|
||
| return ret; | ||
| } | ||
|
|
||
| private void verifyAssetAccess(AtlasEntityHeader asset, AtlasPrivilege assetPrivilege, | ||
| AtlasEntity resource, AtlasPrivilege resourcePrivilege) throws AtlasBaseException { | ||
| verifyAccess(asset, assetPrivilege); | ||
| verifyAccess(resource, resourcePrivilege); | ||
| } | ||
|
|
||
| private void verifyAccess(AtlasEntity entity, AtlasPrivilege privilege) throws AtlasBaseException { | ||
| verifyAccess(new AtlasEntityHeader(entity), privilege); | ||
| } | ||
|
|
||
| private void verifyAccess(AtlasEntityHeader entityHeader, AtlasPrivilege privilege) throws AtlasBaseException { | ||
| String errorMessage = privilege.name() + " entity: " + entityHeader.getTypeName(); | ||
| AtlasAuthorizationUtils.verifyAccess(new AtlasEntityAccessRequest(typeRegistry, privilege, entityHeader), errorMessage); | ||
| } | ||
| } |
Oops, something went wrong.