feat: add connect_args support to DatabaseConfig #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional connect_args field to DatabaseConfig for passing driver-specific
connection arguments directly to SQLAlchemy's create_engine/create_async_engine.
Changes:
- Added connect_args field to DatabaseConfig model with default value {}
- Updated BaseSQLClient.load() to use DB_CONFIG.connect_args instead of instance attribute
- Updated AsyncBaseSQLClient.load() to use DB_CONFIG.connect_args
- Removed sql_alchemy_connect_args parameter from client constructors
Signed-off-by: inishchith <[email protected]>
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 75.4%) Detailed Coverage Report |
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/feat/support-connect-args |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/784 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📦 Example workflows test results
|
📦 Example workflows test results
|
📦 Example workflows test results
|
OnkarVO7
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Note
Adds connect_args to DatabaseConfig and uses DB_CONFIG.connect_args when creating SQLAlchemy engines; enforces DB_CONFIG presence; updates docs and tests.
DB_CONFIG.connect_argsforcreate_engine/create_async_engineinstead ofsql_alchemy_connect_args.sql_alchemy_connect_argsattribute/constructor param and references.DB_CONFIGis set inload()for both sync and async clients.DatabaseConfigwithconnect_args: Dict[str, Any].parametersdescription with connection-string example.connect_argsinDB_CONFIGand example usage.DB_CONFIGand assertconnect_argspropagation.DB_CONFIG.connect_args.Written by Cursor Bugbot for commit 59d3ee8. This will update automatically on new commits. Configure here.
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance