-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add server side session storage #265
Open
patrick-hofmann
wants to merge
4
commits into
atinux:main
Choose a base branch
from
patrick-hofmann:feature/add-server-side-session-storage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add server side session storage #265
patrick-hofmann
wants to merge
4
commits into
atinux:main
from
patrick-hofmann:feature/add-server-side-session-storage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2024
atinux
reviewed
Nov 4, 2024
atinux
reviewed
Nov 4, 2024
Co-authored-by: Sébastien Chopin <[email protected]>
README.md
Outdated
if (session && Object.keys(session).length > 0) { | ||
await setUserSession(event, session) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
)
is missing at the end here ;)
Co-authored-by: Robin Simonklein <[email protected]>
I did not forget, will have a deeper look next week as I want to be confident with the API changes. |
No problem, take the time you need |
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a server side storage option for sessions using
useStorage
.The default behavior after this PR is still the same as before (using cookie as storageType which is the default)
but now the storageType can be
memory
,cache
ornuxt-session
as well, wherenuxt-session
is a nitro storage mount point that can be defined in thenuxt.config.ts
.The 'non-cookie' storageTypes allow two more configs:
The
sessionInactivityMaxAge
is used to determine orphaned sessions that can be deleted withcleanupOrphanedUserSessions
, which can run in a scheduled nitro task (unfortunately not on the edge) or in a server middleware or a specific route.The session data is not encrypted to the server which can be discussed as the stored data is obvious at least in transfer to the server side anyway.
What this PR can not do, is determining multiple sessions of one user as this would need a server side user id, independent from the auth provider used (since one user could have multiple different providers).