Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow 5000 rows #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow 5000 rows #80

wants to merge 1 commit into from

Conversation

akshat-g
Copy link
Contributor

@akshat-g akshat-g commented Jun 25, 2024

Summary by CodeRabbit

  • New Features

    • Increased dataset row limit from 1000 to 5000 when adding rows.
  • Documentation

    • Updated error messages to reflect the new row limit of 5000 in dataset creation examples.
  • Chores

    • Incremented the version number to 1.4.20.

Copy link
Contributor

coderabbitai bot commented Jun 25, 2024

Walkthrough

The recent changes involve adjusting the row limit check for datasets from 1000 to 5000, updating error messages accordingly, and incrementing the project version in the pyproject.toml. These updates ensure larger datasets can be handled without errors and reflect this enhancement in the project version.

Changes

Files Change Summary
athina/datasets/dataset.py Updated limit check from 1000 to 5000 rows
examples/dataset_creation.ipynb Modified error message from 1000 to 5000 rows
pyproject.toml Updated project version from 1.4.19 to 1.4.20

Poem

Amidst the code where limits grew,
Five thousand rows can now pass through.
Version bump, a new delight,
We handle data day and night.
🐇✨ Cheers to growth in lines of gold,
Our dataset's tale, so bold! 📊✨


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
athina/datasets/dataset.py (1)

Line range hint 61-61: Consider removing unused exception variable.

The variable e is declared but never used, which could be cleaned up to enhance code clarity.

-            except Exception as e:
+            except Exception:
                raise

Also applies to: 90-90

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 78fe9ac and a443f53.

Files selected for processing (3)
  • athina/datasets/dataset.py (1 hunks)
  • examples/dataset_creation.ipynb (1 hunks)
  • pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (2)
  • examples/dataset_creation.ipynb
  • pyproject.toml
Additional context used
Ruff
athina/datasets/dataset.py

61-61: Local variable e is assigned to but never used (F841)

Remove assignment to unused variable e


90-90: Local variable e is assigned to but never used (F841)

Remove assignment to unused variable e

Additional comments not posted (4)
athina/datasets/dataset.py (4)

83-83: Updated row limit to 5000 approved.

The change in the row limit from 1000 to 5000 is reflected in the exception message correctly.


Line range hint 33-59: Method create looks well-implemented.

The method handles dataset creation with appropriate error handling and data filtering. No changes are necessary here.


Line range hint 96-101: Method fetch_dataset_rows is correctly implemented.

This method efficiently fetches dataset rows and handles optional limits on the number of rows.


Line range hint 103-105: Method dataset_link functions as expected.

This utility method correctly constructs and returns a dataset link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant