YouTube Shell/Remixer Queries URL for default start/end times #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few comments above. after addressing, looks good to merge |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #122 . The YouTube Remixer now sets clip selection according to the URL, if available. Supported time formats:
t=<n>t=<n1>m<n2>sstart=<n1>m<n2>send=<n>Currently, this functionality is limited to YouTube videos, but
initializeDefaultClipcan be moved up to LinkShell in general in order to handle other URL parameters (if relevant).This pull request also introduces a new utility function
acorn.util.fetchParameters. This function takes a URL and an array of parameters and returns an object with the parameters and their values, if available. If the parameters are not present, then they are not in the object. In the case that no parameters are supplied in the URL, the empty object is returned.