Skip to content

LSM partition option tweaks #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

LSM partition option tweaks #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ufos/src/storage_fjall.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use crate::{
};
use async_trait::async_trait;
use fjall::{
compaction::{Leveled, Strategy},
Batch as FjallBatch, Config, Keyspace, PartitionCreateOptions, PartitionHandle, Snapshot,
};
use jetstream::events::Cursor;
Expand Down Expand Up @@ -162,8 +163,22 @@ impl StorageWhatever<FjallReader, FjallWriter, FjallBackground, FjallConfig> for

let global = keyspace.open_partition("global", PartitionCreateOptions::default())?;
let feeds = keyspace.open_partition("feeds", PartitionCreateOptions::default())?;
// TODO: value separation + gc will probably work
// then *maybe* also a tall tree to help deletes happen?
let records = keyspace.open_partition("records", PartitionCreateOptions::default())?;
let rollups = keyspace.open_partition("rollups", PartitionCreateOptions::default())?;
// try to make the tree narrower so deletes eventually bottom out and are removed
// when fjall finally gets weak delete (rocksdb "single delete") that will work way better
// ...not sure if changing the strategy after creation actually works
// TODO: also increase block size
let rollups = keyspace.open_partition(
"rollups",
PartitionCreateOptions::default().compaction_strategy(Strategy::Leveled(Leveled {
target_size: 16 * 2_u32.pow(20), // MiB (default 64)
level_ratio: 2, // this is a little extreme? (default 10)
..Default::default()
})),
)?;

let queues = keyspace.open_partition("queues", PartitionCreateOptions::default())?;

let js_cursor = get_static_neu::<JetstreamCursorKey, JetstreamCursorValue>(&global)?;
Expand Down