Use a trait-based design for stop-token. #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3, #4.
This PR changes
stop-token
to use a trait-based API, rather than creating futures directly fromStopToken
. This sets us up to also be able to generate alternate deadlines from e.g.std::time::{Instant, SystemTime}
.Usage Example
The "shiny future" variant of this I envision (everything in preludes, all part of std, lang features stable) would be closer to this:
Which I think would be quite nice to use!