-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft Buf writer #92
draft Buf writer #92
Conversation
I think this PR could use some tests, especially around how BufWriter is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we perhaps move LineWriter
into a new pull request to keep this one simple?
Ref #131 also (tracking issue for |
@Drevoed o/ wanted to check in how things are. Is there anything we can do to help you get unblocked? |
@yoshuawuyts I'm currently a bit busy with day-time job but will try to implement requested changes ASAP, I don't think I will have any problems, but if I will - I am going to ask for assistance surely :) |
Signed-off-by: Kirill Mironov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch looks excellent to me! -- I think we should go ahead and merge this in. Thanks so much for all the work you've put into this; this is really good!
This pull request will resolve #83 when merged.
It includes asynchronous BufWriter and LineWriter with tests.
Currently I'm having problems with implementing
poll_write
for BufWriter, because trying to callself.buf().write(buf).poll(cx)
results inI assume that's because WriteFuture has trait bounds on ?Sized but I'm not sure how to get around that.The above error was fixed by wrapping the buf in Pin explicitly.
Previous PR was closed because I forgot to mark it as draft.