Conversation
Collaborator
|
I think this PR could use some tests, especially around how BufWriter is used. |
ghost
previously requested changes
Aug 27, 2019
ghost
left a comment
There was a problem hiding this comment.
Can we perhaps move LineWriter into a new pull request to keep this one simple?
Contributor
|
Ref #131 also (tracking issue for |
Contributor
|
@Drevoed o/ wanted to check in how things are. Is there anything we can do to help you get unblocked? |
Contributor
Author
|
@yoshuawuyts I'm currently a bit busy with day-time job but will try to implement requested changes ASAP, I don't think I will have any problems, but if I will - I am going to ask for assistance surely :) |
Signed-off-by: Kirill Mironov <k.mironov@albato.ru>
yoshuawuyts
approved these changes
Sep 24, 2019
Contributor
yoshuawuyts
left a comment
There was a problem hiding this comment.
This patch looks excellent to me! -- I think we should go ahead and merge this in. Thanks so much for all the work you've put into this; this is really good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will resolve #83 when merged.
It includes asynchronous BufWriter and LineWriter with tests.
Currently I'm having problems with implementing
poll_writefor BufWriter, because trying to callself.buf().write(buf).poll(cx)results inI assume that's because WriteFuture has trait bounds on ?Sized but I'm not sure how to get around that.The above error was fixed by wrapping the buf in Pin explicitly.
Previous PR was closed because I forgot to mark it as draft.