-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stream::count #368
Merged
Merged
add stream::count #368
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a9a7bdc
add stream::count
starsheriff 97094b2
remove Sized constraint
starsheriff 6608d39
remove Stream trait bound
starsheriff 75546ef
Merge branch 'master' into stream_count
starsheriff 60f822b
Merge branch 'master' into stream_count
starsheriff 7d2282d
fix merge conflict
starsheriff 3792240
use pin_project
starsheriff 9ebe41f
Update src/stream/stream/mod.rs
starsheriff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
use std::pin::Pin; | ||
|
||
use crate::future::Future; | ||
use crate::stream::Stream; | ||
use crate::task::{Context, Poll}; | ||
|
||
#[doc(hidden)] | ||
#[allow(missing_debug_implementations)] | ||
pub struct CountFuture<S> { | ||
stream: S, | ||
count: usize, | ||
} | ||
|
||
impl<S> CountFuture<S> { | ||
pin_utils::unsafe_pinned!(stream: S); | ||
pin_utils::unsafe_unpinned!(count: usize); | ||
|
||
pub(crate) fn new(stream: S) -> Self { | ||
CountFuture { stream, count: 0 } | ||
} | ||
} | ||
|
||
impl<S> Future for CountFuture<S> | ||
where | ||
S: Stream, | ||
{ | ||
type Output = usize; | ||
|
||
fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> { | ||
let next = futures_core::ready!(self.as_mut().stream().poll_next(cx)); | ||
|
||
match next { | ||
Some(_) => { | ||
cx.waker().wake_by_ref(); | ||
*self.as_mut().count() += 1; | ||
Poll::Pending | ||
} | ||
None => Poll::Ready(self.count), | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rebase this branch and use
pin_project!
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, can do that. Sorry for the late reply, I was quite busy the last weeks.