-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes feature flag used in generating the docs in the README #278
Conversation
I think it would be good to use
Maybe the other way around instead. :) We use |
Per Stjepan Glavina, this flag is superfluous because #[cfg(any(feature = "unstable", feature = "docs"))] is used everywhere in the codebase. Discussion: async-rs#278 (comment)
I've added It looks like Lines 28 to 31 in ddee472
I'm not yet familiar enough to know if that should be changed because it looks it might be handled in another way there. |
@Michael-J-Ward That's a good catch! This line: #[cfg(feature = "unstable")] should be replaced with: #[cfg(any(feature = "unstable", feature = "docs"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+ |
bors is hanging, merging this manually! |
I thought I'd take a stab at fixing at this #82, but I ran into a few errors following the instruction in the README.md
The first error and one that is addressed in this pull request is that the feature flag used to generate the docs is incorrect- it should be
docs
and notdocs.rs
Perhaps additionally, it should be
--features docs,unstable
as it is in.travis.yml
. Should I add that to the README? https://github.com/async-rs/async-std/blob/master/.travis.yml#L53Lastly, I had to use the
+nightly
flag to get it to the docs and example to run. Should I add this or is it assumed that the user would have this configured somewhere?Thanks!