Add Stream::scan #192
Merged
Add Stream::scan #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Sep 15, 2019
| where | ||
| Self: Sized, | ||
| St: Unpin, | ||
| F: Unpin + FnMut(&mut St, Self::Item) -> Option<B>, |
There was a problem hiding this comment.
We don't need St nor F to be Unpin because we're never pinning them.
ghost
approved these changes
Sep 15, 2019
|
Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 15, 2019
192: Add Stream::scan r=stjepang a=tirr-c Ref #129. The mapper function `f` is synchronous and returns bare `Option<B>`. Asynchronous `f` seems tricky to implement right. It requires the wrapper to be self-referential, as a reference to internal state may be captured by the returned future. Co-authored-by: Wonwoo Choi <[email protected]>
Build succeeded
|
bors bot
added a commit
that referenced
this pull request
Sep 16, 2019
196: Remove more Unpin bounds for Stream::scan r=stjepang a=tirr-c cc #192. I missed the bounds on `Stream::scan` itself. Co-authored-by: Wonwoo Choi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #129. The mapper function
fis synchronous and returns bareOption<B>.Asynchronous
fseems tricky to implement right. It requires the wrapper to be self-referential, as a reference to internal state may be captured by the returned future.