Skip to content

Add BufRead::consume #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Add BufRead::consume #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab0a4cb
remove pin<self> bounds from consume
yoshuawuyts Sep 10, 2019
10fedfe
implement feedback for bufreader methods
yoshuawuyts Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/io/buf_read/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ cfg_if! {
/// [`futures::io::AsyncBufRead`]:
/// https://docs.rs/futures-preview/0.3.0-alpha.17/futures/io/trait.AsyncBufRead.html
pub trait BufRead {
/// Tells this buffer that `amt` bytes have been consumed from the buffer, so they should no
/// longer be returned in calls to `read`.
fn consume(&mut self, amt: usize)
where
Self: Unpin;

/// Returns the contents of the internal buffer, filling it with more data from the inner
/// reader if it is empty.
///
Expand Down Expand Up @@ -217,7 +223,11 @@ pub trait BufRead {
}
}

impl<T: AsyncBufRead + Unpin + ?Sized> BufRead for T {}
impl<T: AsyncBufRead + Unpin + ?Sized> BufRead for T {
fn consume(&mut self, amt: usize) {
AsyncBufRead::consume(Pin::new(self), amt)
}
}

pub fn read_until_internal<R: AsyncBufRead + ?Sized>(
mut reader: Pin<&mut R>,
Expand Down