fixes to stream::min_by #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref #146. |
bors bot
added a commit
that referenced
this pull request
Sep 10, 2019
163: adds stream::filter_map combinator r=yoshuawuyts a=montekki Implements a `flat_map` combinator. Currently the same about `ret!` as in #162 . Also the naming should probably be `FilterMapStream`, but in that case `Take` stream should also change it's name i guess. Stdlib: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.flat_map Ref: #129 Co-authored-by: Fedor Sakharov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min_byshould not have aSelf: Unpinbound.unsafe_pinnedinstead of anUnpinbound in theimpls.waker().wake_by_ref()line in place since here we are returningPoll::Pendingupon receiving new elements from theinnerstream and need to re-schedule ourselves to receive new elements (as inAllFuture)ret!macro should be used for returning types without explicit lifetimes. That's the case forTakeandMinByFuture.