Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split stream into multiple files #150

Merged
2 commits merged into from
Sep 8, 2019
Merged

split stream into multiple files #150

2 commits merged into from
Sep 8, 2019

Conversation

yoshuawuyts
Copy link
Contributor

This splits stream/mod.rs's combinators into multiple files, making it easier to contribute combinators. Additionally we've renamed MinBy to MinByFuture to make it the same as the other private futures. Ref #146 #129. Thanks!

@yoshuawuyts
Copy link
Contributor Author

cargo fmt is failing because it's broken on nightly https://travis-ci.com/async-rs/async-std/jobs/231806192 -- this patch should be good to merge tho!

Signed-off-by: Yoshua Wuyts <[email protected]>
@yoshuawuyts yoshuawuyts requested a review from a user September 7, 2019 22:41
bors bot added a commit that referenced this pull request Sep 8, 2019
151: Split io into multiple files r=stjepang a=yoshuawuyts

Counterpart to #150, splits `io::read` and `io::write` into multiple files. This is useful to prevent a single file from becoming hard to navigate as we add more combinators. No other changes were made. Ref #131. Thanks!

Co-authored-by: Yoshua Wuyts <[email protected]>
@ghost
Copy link

ghost commented Sep 8, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 8, 2019
149: update deps r=stjepang a=yoshuawuyts

Updates all deps. Thanks!

150: split stream into multiple files r=stjepang a=yoshuawuyts

This splits `stream/mod.rs`'s combinators into multiple files, making it easier to contribute combinators. Additionally we've renamed `MinBy` to `MinByFuture` to make it the same as the other private futures. Ref #146 #129. Thanks!

Co-authored-by: Yoshua Wuyts <[email protected]>
Co-authored-by: Stjepan Glavina <[email protected]>
@ghost ghost merged commit ba43a05 into master Sep 8, 2019
@ghost ghost deleted the split-stream branch September 8, 2019 10:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant