-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify documentation links on travis #138
Conversation
@stjepang when you have a moment would you please take a look at this and let me know if it's what you had in mind for resolving #82? I think this should fix all the current errors produced by If it looks okay, I'll squash the commits and mark it ready for review. One thing that will probably need to be changed is the installation step for |
|
||
cfg_if! { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also delete this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I delete these doc shims in src/os/unix/fs.rs
, then I start to get errors like this:
Found invalid urls in async-std/target/doc/async_std/os/unix/fs/index.html:
Linked file at path async-std/target/doc/std/fs/struct.OpenOptions.html does not exist!
I tried to trace back to where all of these are being referenced but wasn't successful. Do you still want to try and remove them?
Yes, that sounds reasonable to me! |
@stjepang Thanks for the feedback! Responding to a few specific points you raised:
Finally, installing Given that, I'm not sure how you want to handle the installation. Thoughts? (cc @jamesmunns) Otherwise, I've made the requested changes. |
Going to close this. If someone would like to resume the work, feel free to ping me. |
Fixes #82