Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace futures-timer with a hash-wheel timer #170

Open
yoshuawuyts opened this issue Sep 9, 2019 · 1 comment
Open

Replace futures-timer with a hash-wheel timer #170

yoshuawuyts opened this issue Sep 9, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Sep 9, 2019

futures-timer is quite naive in its implementation, and we can probably do better. Something we may want to consider is building a hash-wheel timer impl to replace the existing timer.

mozilla/neqo#127 (http/3 impl) has a relatively small implementation we may want to adopt (200 lines!). Though worth keeping an eye on mozilla/neqo#190, where they're investigating possible other solutions.

Either way I think it's probably worth spinning up our own crate for this, and moving away from futures-timer. I've also gone and reserved the hash-wheel-timer name so we publish after we've built it.

Also if anyone's interested in taking this on feel free to comment below. This is not a high priority, but generally could make for some nice improvements. Thanks!

@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Sep 9, 2019
@yoshuawuyts yoshuawuyts changed the title Replace futures-timer with a custom timer impl Replace futures-timer with a hash-wheel timer Sep 9, 2019
@yoshuawuyts yoshuawuyts changed the title Replace futures-timer with a hash-wheel timer Replace futures-timer with a hash-wheel timer Sep 9, 2019
@yoshuawuyts yoshuawuyts changed the title Replace futures-timer with a hash-wheel timer Replace futures-timer with a hash-wheel timer Sep 9, 2019
@montekki montekki self-assigned this Oct 17, 2019
@montekki
Copy link
Member

@yoshuawuyts I will try to look into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants