Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency on futures_timer #275

Closed
1 task done
yoshuawuyts opened this issue Oct 5, 2019 · 3 comments · Fixed by #298 or #317
Closed
1 task done

Reduce dependency on futures_timer #275

yoshuawuyts opened this issue Oct 5, 2019 · 3 comments · Fixed by #298 or #317
Assignees
Labels
enhancement New feature or request feedback wanted Needs feedback from users good first issue Good for newcomers

Comments

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Oct 5, 2019

In preparation for #170, we should reduce the API surface of any new dependency and make it easier to swap between implementations.

To that extent it's probably best if we only rely on futures_timer::Delay, and remove our dependency on other parts of the futures-timer crate.

Once that's done we can vastly reduce the API surface of futures-timer itself, and then create a new crate that implements the same (much smaller) API surface.

This should be reasonably straight forward, and fairly easy to pick up. So this is marked as "good first issue". If someone wants to pick this up it'd be greatly appreciated!

Tasks

  • src/io/timeout.rs remove dependency on futures_timer::TryFutureExt by inlining the logic.
@yoshuawuyts yoshuawuyts added enhancement New feature or request feedback wanted Needs feedback from users good first issue Good for newcomers labels Oct 5, 2019
@shaikh-raj
Copy link

Can I pick this one?

@yoshuawuyts
Copy link
Contributor Author

@shaikh-raj for sure! Thanks for volunteering!

@yoshuawuyts
Copy link
Contributor Author

@shaikh-raj wanted to briefly check in with how are things going ✨ -- no rush at all, but want to make sure you're not stuck either!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feedback wanted Needs feedback from users good first issue Good for newcomers
Projects
None yet
2 participants