Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies of async-log-attributes and make it to be optional #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koushiro
Copy link

Signed-off-by: koushiro [email protected]

@koushiro
Copy link
Author

@yoshuawuyts PTAL :)
Could you publish a patch version if the PR is merged ?

@Keruspe
Copy link
Member

Keruspe commented May 23, 2020

Now that tide depends on femme, it pulls in async-log-attributes and it's sad to see proc-macro2/syn/quote 0.x get back in the dependency tree.
This would be greatly appreciated to avoid duplicate dependencies.

@yoshuawuyts BTW, when you merge and make a release out of this, you should s/runtime/async-log/ in several places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a feature to disable proc-macro support
2 participants