This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
Rename server functions to follow *_loop convention #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Sep 2, 2019
src/bin/server.rs
Outdated
| @@ -80,7 +80,7 @@ async fn client(mut broker: Sender<Event>, stream: TcpStream) -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| async fn client_writer( | |||
| async fn client_writer_loop( | |||
There was a problem hiding this comment.
Suggested change
| async fn client_writer_loop( | |
| async fn connection_writer_loop( |
|
bors r+ |
|
bors ping ? |
|
pong |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 2, 2019
7: Rename server functions to follow *_loop convention r=matklad a=kachayev Described here: async-rs/async-std#106 If new names sound okay, I would submit PR for the book. Co-authored-by: Oleksii Kachaiev <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described here: async-rs/async-std#106
If new names sound okay, I would submit PR for the book.