781 new member onboarding spring 2025 course discussion board#1061
Open
marla-tumenjargal wants to merge 5 commits intomainfrom
Open
781 new member onboarding spring 2025 course discussion board#1061marla-tumenjargal wants to merge 5 commits intomainfrom
marla-tumenjargal wants to merge 5 commits intomainfrom
Conversation
Linting FailedNote: The status check will always pass. Run Click to expand lint output |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4698963e1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+4
to
+6
| export default { | ||
| typeDef: discussionTypeDefs, | ||
| resolver, |
There was a problem hiding this comment.
This module is defined but never added to the backend module registry (apps/backend/src/modules/index.ts), so its typeDef/resolver are never merged into the GraphQL schema. Any client querying courseComments/addCourseComment will get schema errors like “Cannot query field” because the schema doesn’t include this module. Please add the discussion module to the modules array so the new discussion API is actually exposed.
Useful? React with 👍 / 👎.
Comment on lines
+35
to
+41
| const response = await fetch( | ||
| `/api/comments?subject=${encodeURIComponent(classData.subject)}&course_number=${encodeURIComponent(classData.courseNumber)}`, | ||
| { | ||
| method: "GET", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, |
There was a problem hiding this comment.
The UI is wired to GET /api/comments and POST /api/comments, but the backend only adds a GraphQL discussion module and there is no REST route or API handler for /api/comments in this repo. As a result, these fetches will 404 and the discussion tab will always show errors/empty state in production unless a matching REST endpoint is added or the client is switched to the GraphQL API.
Useful? React with 👍 / 👎.
Linting FailedNote: The status check will always pass. Run Click to expand lint output |
ARtheboss
requested changes
Feb 8, 2026
Contributor
ARtheboss
left a comment
ARtheboss
left a comment
There was a problem hiding this comment.
Make sure you test your changes before you submit them.
| setIsLoading(true); | ||
| setError(null); | ||
|
|
||
| // Call your backend GET endpoint |
Comment on lines
+68
to
+77
| const response = await fetch("/api/comments", { | ||
| method: "POST", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, | ||
| body: JSON.stringify({ | ||
| subject: classData.subject, | ||
| course_number: classData.courseNumber, | ||
| text: newComment.trim(), | ||
| }), |
Contributor
There was a problem hiding this comment.
This is not correct, it is using a REST API instead of GraphQL. Have you tested this?
Make sure you use useQuery from Apollo Client
Comment on lines
+35
to
+43
| const response = await fetch( | ||
| `/api/comments?subject=${encodeURIComponent(classData.subject)}&course_number=${encodeURIComponent(classData.courseNumber)}`, | ||
| { | ||
| method: "GET", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, | ||
| } | ||
| ); |
Contributor
There was a problem hiding this comment.
Also not correct. We use Apollo Client hooks
Comment on lines
+4
to
+21
| type Comment { | ||
| id: ID! | ||
| courseId: String! | ||
| userId: String! | ||
| content: String! | ||
| createdAt: String! | ||
| } | ||
|
|
||
| type Query { | ||
| courseComments(courseId: String!, userId: String): [Comment!]! | ||
| } | ||
|
|
||
| type Mutation { | ||
| addCourseComment( | ||
| courseId: String! | ||
| content: String! | ||
| ): Comment! | ||
| } |
Contributor
There was a problem hiding this comment.
There's nothing I see here that deals with the caching problem I was talking about
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.