BUG: Fix issues related to kwarg only changes in utils.tap #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 7, 2023 13:57
cosmoJFH
changed the title
|
Thanks @cosmoJFH , I am currently testing it in other ESA modules, so maybe more changes are required. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2892 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 235 235
Lines 18114 18116 +2
=======================================
+ Hits 12052 12054 +2
Misses 6062 6062 ☔ View full report in Codecov by Sentry. |
|
@cosmoJFH - Thank you for the PR. I'll hold-off merging until @jespinosaar gives the thumbs up that all is good with the rest of the ESA modules. I'm sorry for not catching these in the review cycle of #2690 |
|
(I also wonder, how and why we didn't see more failures from all of these before, none of them are covered sufficiently with tests?) |
bsipocz
changed the title
bsipocz
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue #2884, it was detected a problem related to the function Gaia.launch_job.
It looks like this is related to the commit
Tsar Bomba Nick 18/3/23 1:15 Refactor: Made kwargs keyword only for astroquery/utils/tap/tapconn.py
rev number: e724f62
where the the function in astroquery/utils/tap/tapconn.py were made kwargs keyword
We have analysed the changes carried out in that commit, and more classes are affected.
cc @esdc-esac-esa-int