Fix esasky remote tests
#2672
Merged
Fix esasky remote tests
#2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2672 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 304 304
Lines 22524 22524
=======================================
Hits 15580 15580
Misses 6944 6944 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bsipocz
reviewed
Feb 18, 2023
Comment on lines
121
to
123
| result = ESASky.get_images( | ||
| position="M51", missions=mission, download_dir=tmp_path | ||
| ) |
There was a problem hiding this comment.
keep these long, we use line length 120.
There was a problem hiding this comment.
I've merged the line triplets.
Comment on lines
+88
to
+89
| for hdu_list in result[mission.upper()]: | ||
| hdu_list.close() |
There was a problem hiding this comment.
Thanks. I wonder whether this should rather be dealt with by a context manager somewhere in the module instead, but I suppose getting a workaround in the test would do for now.
The two reasons the tests were failing were not using uppercase filenames for file existence checks where needed and not closing HDULists.
eerovaher
force-pushed
the
fix-esasky-tests
branch
from
8e9b2f0
to
8644ab7
Compare
bsipocz
approved these changes
Feb 21, 2023
|
Thanks @eerovaher! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two reasons the tests were failing were not using uppercase filenames for file existence checks where needed and not closing HDULists.
Contributes towards #2634